Merged
Conversation
rswanson
approved these changes
Oct 29, 2024
Evalir
added a commit
that referenced
this pull request
Apr 27, 2026
Address PR #259 nit #2: full_fetch was named like a pure data accessor but actually dispatched nonce-check tasks per tx. Restore check_tx_cache as a private pure-fetch helper returning Result<Vec<TxEnvelope>, _>, and rename full_fetch to fetch_and_dispatch — its name now matches what it does. The orchestrator uses let-else over the fetch result to drop a level of indentation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Evalir
added a commit
that referenced
this pull request
Apr 29, 2026
Address PR #259 nit #2: full_fetch was named like a pure data accessor but actually dispatched nonce-check tasks per tx. Restore check_tx_cache as a private pure-fetch helper returning Result<Vec<TxEnvelope>, _>, and rename full_fetch to fetch_and_dispatch — its name now matches what it does. The orchestrator uses let-else over the fetch result to drop a level of indentation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow builder to broadcast to multiple endpoints
@rswanson
new env var. format is comma-separated url strings. Https and wss supported.
http://whatever.com,https://kasldfkj.org,wss://thisisarealwebsite.netmissing is acceptable